fix: add timeout to streaming subprocess.run() in base.py - #3967
Open
Quratulain-bilal wants to merge 1 commit into
Open
fix: add timeout to streaming subprocess.run() in base.py#3967Quratulain-bilal wants to merge 1 commit into
Quratulain-bilal wants to merge 1 commit into
Conversation
…mmand The streaming branch of dispatch_command() called subprocess.run() without a timeout, which could hang indefinitely if the child process stalls. Now uses the same timeout parameter (default 600s) as the non-streaming branch, with proper TimeoutExpired handling.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds timeout protection to streaming integration commands, preventing stalled subprocesses from hanging indefinitely.
Changes:
- Passes the configured timeout to streaming subprocesses.
- Converts timeout failures into exit code 124 with a clear error.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/integrations/base.py |
Adds streaming timeout enforcement and handling. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
| exec_args, | ||
| text=True, | ||
| cwd=cwd, | ||
| timeout=timeout, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The streaming branch of dispatch_command() called subprocess.run() without a timeout, which could hang indefinitely if the child process stalls.
Fix
Apply the same timeout parameter (default 600s) as the non-streaming branch, with proper TimeoutExpired handling.